feat(rpc): make controller decorator name optional #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rpc controller metadata name would then default to the name of the class Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
marcus-sa
changed the title
Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 78.25% 78.26% +0.01%
==========================================
Files 186 186
Lines 19761 19763 +2
Branches 5082 5083 +1
==========================================
+ Hits 15463 15467 +4
+ Misses 4298 4296 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
marcj
reviewed
Oct 30, 2023
|
Thanks! |
@marcj what do you think about adding a reusable function for getting the name of a class type? function getClassTypeName(classType: ClassType): string {
return reflect(classType).typeName || classType.name;
} |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use case: not having to explicitly specify a name for a controller
https://github.com/marcus-sa/ngkit/blob/main/apps/example-cli/src/app.controller.ts
Relinquishment of Rights
Please mark following checkbox to confirm that you relinquish all rights of your changes: